Objective: To understand what attributes were considered important for an effective Family Medicine clinical teacher among residents and faculty members. Methods: An online survey of 15 attributes was sent to 16 residents and 24 faculty members at the National University Health System Family Medicine Residency program. Residents and faculty members were asked to choose the 5 most important and the 5 least important attributes for an effective clinical teacher. Results: Response rate was 87.5% for residents and 50% for faculty members. Both clinical competence and role modeling were considered important attributes by residents and faculty members. Scholarly activities and organisational skills were felt to be among the least important attributes that make an effective teacher. Role modeling was felt to be the one attribute that was most important while involving in scholarly activities was considered the least important for clinical teacher. Conclusions: Good role modeling in Family Medicine teaching was considered important for clinical teacher. Though not viewed as an important attribute, involvement in scholarly activities should still play significant role in the Family Medicine residency curriculum. Besides good role modeling, residents valued a non-threatening learning environment with competent teachers who were available, enthusiastic and clear in their teaching.